fix: clarify error message when starting docker container#4790
Merged
avallete merged 2 commits intosupabase:developfrom Apr 7, 2026
Merged
Conversation
unlair
force-pushed
the
fix/indicate-which-container-failed-in-error-msg
branch
from
3c3b4c0 to
42266b4
Compare
Coverage Report for CI Build 24085779964Coverage decreased (-0.02%) to 63.824%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions5 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
unlair
force-pushed
the
fix/indicate-which-container-failed-in-error-msg
branch
from
42266b4 to
97f8bfd
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe DockerStart function's error handling was modified to include the container name in the wrapped error message. The format string changed from "failed to start docker container: %w" to "failed to start docker container %q: %w", containerName, err. No other logic, control flow, or public signatures were changed. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
unlair
force-pushed
the
fix/indicate-which-container-failed-in-error-msg
branch
from
97f8bfd to
ab6464d
Compare
unlair
force-pushed
the
fix/indicate-which-container-failed-in-error-msg
branch
2 times, most recently
from
e1e0505 to
a0c7e8e
Compare
unlair
force-pushed
the
fix/indicate-which-container-failed-in-error-msg
branch
from
a0c7e8e to
9adb2c0
Compare
Error message was not indicating which Docker container failed to start, forcing the user to use a process of elimination to narrow down the problem.
unlair
force-pushed
the
fix/indicate-which-container-failed-in-error-msg
branch
from
524b86a to
dd828ad
Compare
avallete
approved these changes
Apr 7, 2026
Member
|
Thank's for your contribution ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error message was not indicating which Docker container failed to start, forcing the user to use a process of elimination to narrow down the problem.
What kind of change does this PR introduce?
Bug fix (updating error message).
What is the current behavior?
When an error is returned when starting a Docker container (e.g. #3593 the error message reads:
failed to start docker container: <some error>What is the new behavior?
The error message reads:
failed to start docker container "<container name>": <some error>